Closed leocov-dev closed 4 weeks ago
Hello! Thank you @leocov-dev for working to make this a PyPi package. That would be a much cleaner/nicer way to incorporate this into other projects (Like the PiFinder :-) I hope this can be merged soon along with some of the Cedar fork improvements :+1:
Sorry, this PR doesn't belong here, and I don't known how to delete it.
we will prove out this work in the cedar-solve
fork on the PyPi branch.
https://github.com/smroid/cedar-solve/tree/PyPi
https://github.com/smroid/cedar-solve/issues/6
I'm coming to this project from PiFinder and having noticed that they include tetra3 as a submodule since tetra3 is not available from PyPi.
I have experience with build/release workflows for python projects and wanted to contribute an option to make it easy for tetra3 to build wheels and publish to PyPi.
To that end this PR includes:
setup.py
configuration file to the modernpyproject.toml
format1.2.3
Tetra3.generate_database(...)
so that thestar_catalog
argument may accept a path, this lets the function work better when used as an installed library.I realize this is a significant change. Let me know what you think, if you are interested in any of these options or if you'd like to break this up into smaller chunks.