modernize tilings.jl - Githubissues

esabo / CodingTheory

A coding theory library for Julia.

https://esabo.github.io/CodingTheory/

BSD 3-Clause "New" or "Revised" License

26 stars 11 forks source link

modernize tilings.jl #9

Closed kalmarek closed 1 year ago

kalmarek commented 1 year ago

replace direct accesses to fields of ReflectionGroup by accessors
use more functional julia syntax

Note: Since I can't use LowIndexNormalSubgroupsSearchForAll please test the changes thoroughly ;)

MikeVasmer commented 1 year ago

The above are things I spotted just looking through the code, I will also do some tests on examples

MikeVasmer commented 1 year ago

@kalmarek I made the changes as we discussed above and tested everything. I think it's ready to merge. Thanks for your help :)

benide commented 1 year ago

I looked over it, seems good. If it works in your testing then I consider it ready. Thanks!

benide commented 1 year ago

@MikeVasmer and @esabo, should we bring this into the subsystem branch? Mike, I'm not sure if you need this immediately with that branch, but I expect if you do you've already copied it over locally anyway. Eventually (soon?) subsystem will be merged into master anyway.

MikeVasmer commented 1 year ago

It will be useful to have in subsystem to construct e.g. hyperbolic Floquet codes but I wouldn't say it's urgent