search

esanchezros / quickfixj-spring-boot-starter-examples

QuickFixJ Spring Boot Starter Examples
Other
65 stars 41 forks source link

Why Thread.currentThread().join() ? #14

Closed style-x7 closed 3 years ago

style-x7 commented 3 years ago

Hi there,

Some of the examples are having this line of code, what is it needed?

When I deploy war file of the examples to a shared container server, this is holding up resources from the other war files..

esanchezros commented 3 years ago

Hi @style-x7,

Thanks for bring this up. The Thread.currentThread().join() was part of the original examples as the starter was run as a CommandLineRunner Spring Boot app. As the web context is now available via the actuator, the starter runs now as a webapp, hence the line is obsolete.

I have updated the examples and removed unnecessary code. https://github.com/esanchezros/quickfixj-spring-boot-starter-examples/pull/15

Let me know if you have any questions. Thanks Ed