Beatsync 0 does not set Beatsync Off

esaruoho / org.lackluster.Paketti.xrnx

Quality-of-Life (QoL) Workflow suite of tools for Renoise written with LUA - Continually ingesting and porting features from other tracker software (Impulse Tracker, Scream Tracker, ModPlugTracker, PlayerPro etc)

Other

16 stars 0 forks source link

Beatsync 0 does not set Beatsync Off #18

Closed tkna91 closed 7 months ago

tkna91 commented 8 months ago

(Derived from #16)

Wouldn't it be better to set Beatsync 0 but not Beatsync Off? Since the following works as a Toggle, I think it would be better to operate there.

Set Selected Sample Beatsync On/Off
Set Selected Sample Beatsync On/Off 1 (Repitch)
Set Selected Sample Beatsync On/Off 2 (Time-Stretch Percussion)
Set Selected Sample Beatsync On/Off 3 (Time-Stretch Texture)

esaruoho commented 8 months ago

well, beatsync cannot be set to 0, it can only be set to 1. are you thinking that if i press -1 on a beatsync 1, it should not turn beatsync off, instead do nothing? (cos that's the only thing it can do, really, since 0 is not possible). @tkna91

tkna91 commented 8 months ago

it should not turn beatsync off, instead do nothing? (cos that's the only thing it can do, really, since 0 is not possible).

That is correct.

esaruoho commented 7 months ago

hi, sorry it's taken me so long to get on this. i think and i hope that tonight i'll be able to start scripting with this new machine and be able to take care of these.

esaruoho commented 7 months ago

ok, so i'm gonna close this, since i've now disabled the beatsync=off logic. i'll try and work on finding a method of posting a release of Paketti either via GitHub or by using the Tools website on Renoise. or send you a direct link. But let it be stated, that the change has been made. just not rolled into a xrnx yet.