esaulpaugh / headlong

High-performance Contract ABI and RLP for Ethereum
Apache License 2.0
76 stars 20 forks source link

For more security spongycastle -> bouncycastle #14

Closed Neustradamus closed 4 years ago

Neustradamus commented 4 years ago

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?

esaulpaugh commented 4 years ago

Sure; I was probably going to ditch spongycastle eventually anyway. https://github.com/esaulpaugh/headlong/commit/1fa753af853df5bcf309b9cd42c84038ab8bc813

Neustradamus commented 4 years ago

@esaulpaugh: Thanks! Please do not close it before integration of BouncyCastle.

esaulpaugh commented 4 years ago

spongycastle was only used for tests and bouncycastle 1.65 is already a dependency

Neustradamus commented 4 years ago

@esaulpaugh: Ok! No tests with BouncyCastle?

esaulpaugh commented 4 years ago

bouncycastle is used in main and test https://github.com/esaulpaugh/headlong/blob/87474b767c6fd2cda4bd431d6e2dfbdff29cb09d/src/main/java/com/esaulpaugh/headlong/abi/util/WrappedKeccak.java but only bcprov-jdk15on v1.65

Neustradamus commented 4 years ago

@esaulpaugh: Perfect :)