search

esaulpaugh / headlong

High-performance Contract ABI and RLP for Ethereum
Apache License 2.0
76 stars 20 forks source link

Maybe a wrong file placement #18

Closed laalaguer closed 3 years ago

laalaguer commented 3 years ago

Hi,

I have been using the RLP library with examples, and discovered that:

FloatingPoint.java is under package com.esaulpaugh.headlong.rlp.util; But Integers.java and Strings.java is under package com.esaulpaugh.headlong.util;

Maybe it is better to put them together under some package?

esaulpaugh commented 3 years ago

I believe they used to be under rlp but since I want to avoid abi having any imports from rlp or vice versa, and the abi package depends on Integers and Strings, I moved them to the util package.

laalaguer commented 3 years ago

Ah okay. This is expected.