esausilva / example-create-react-app-express

Example on using create-react-app with a Node Express Backend
https://esausilva.com/2017/11/14/how-to-use-create-react-app-with-a-node-express-backend-api/
MIT License
374 stars 141 forks source link

missing eslint configuration #17

Closed jay-jlm closed 3 years ago

jay-jlm commented 4 years ago

Getting the following error on VS Code

Failed to load the ESLint library for the document /Users/[username]/projects/example-create-react-app-express/engine.js
To use ESLint please install eslint by running npm install eslint in the workspace folder example-create-react-app-express

I suppose this project relies on a global Eslint installation? If so maybe I'd suggest migrating to a local configuration, since global dependencies are no longer the recommend way to use JS dependencies, unless in very specific cases.

esausilva commented 4 years ago

@jay-jlm I do not have ESlint set up locally or globally. And I do not recognize that engine.js file, it is not part of the original project

jay-jlm commented 4 years ago

Yes, engine.js is just a file that I created, but any file will get the same error. (as long as you have your development environment configured to run Eslint locally). Just to make it more clear: the point of the issue is that you can assume that most users these days would have a similar setup that would benefit from an existing local Eslint configuration, if one was available. So this is more of a suggestion of a possible enhancement that would save users from having to configure Eslint manually for this project. Hope that it's more clear now.