esbenp / bruno

A base API controller for Laravel that gives sorting, filtering, eager loading and pagination for your resources
MIT License
165 stars 69 forks source link

Upgrade method names to match with laravel 5.4 #12

Open sgr369 opened 7 years ago

sgr369 commented 7 years ago

In file vendor/optimus/bruno/src/EloquentBuilderTrait.php , there are couple of references of method getForeignKey() they are renamed in laravel 5.4 , replace it with getQualifiedForeignKeyName()

ux-engineer commented 7 years ago

Any progress on this?

denielaa commented 7 years ago

there is no update on the repository currently. my project is using this library and made some changes on it to support laravel 5.4 you can have a look the forked repository here https://github.com/Metabuyer/bruno

still in development though, will create pull request to this repo later on once I think it is stable enough with laravel 5.4

esbenp commented 7 years ago

There is an upcoming PR #20 for this :-)