search

esbenp / react-native-clean-form

Easy react-native forms using bootstrap-like syntax with redux-form+immutablejs integration. Styled using styled-components
http://esbenp.github.io/2017/01/06/react-native-redux-form-immutable-styled-components/
MIT License
478 stars 83 forks source link

Change the android app styles #20

Closed markusguenther closed 7 years ago

markusguenther commented 7 years ago

The style of the android app is not optimal. The most text components are not centered vertically and the input text changes the height depending on the inlineLabel property.

This commit does not remove the input lines because this is a component property of text-input in react native and can be changed in the general behavior.

But to change this you also need the pull request 15.

https://github.com/esbenp/react-native-clean-form/pull/15

Fixes: #9

markusguenther commented 7 years ago

For multiline inputs the alignment should not be centered. Will add this soon (this evening/night)

esbenp commented 7 years ago

There are some conflicts here. Can you resolve those and then I will review again? :-)

markusguenther commented 7 years ago

Ok conflicts has been resolved :)

tylerbuchea commented 7 years ago

What is the word on this? I'm having issues with the forms displaying on Android as well. Would love to have this fix merged in.

markusguenther commented 7 years ago

I guess Esben is on it. He already wrote me that he is busy at the moment.

Stay tuned, it will not take so much time anymore ;)

tylerbuchea commented 7 years ago

Sorry for being pushy I didn't look at how recent this PR was before I commented. Your response time is more than satisfactory. Thanks for all the hard work @esbenp and @markusguenther 😄

markusguenther commented 7 years ago

No problem ... your welcome :)