search

esbenp / react-native-clean-form

Easy react-native forms using bootstrap-like syntax with redux-form+immutablejs integration. Styled using styled-components
http://esbenp.github.io/2017/01/06/react-native-redux-form-immutable-styled-components/
MIT License
478 stars 76 forks source link

Not working with Expo Or create-react-native-app #41

Closed giautm closed 7 years ago

giautm commented 7 years ago

This package currently can't work with Expo. Because it used react-native-vector-icons. Can be change to @expo/vector-icon to make very body be happy? 👍

sabativi commented 7 years ago

@expo/vector-icon has the same api as react-native-vector-icons

https://docs.expo.io/versions/v17.0.0/guides/icons.html

expo/vector-icons is built on top of react-native-vector-icons and uses a similar API. The only difference is @expo/vector-icons uses a more idiomatic import style:

import { Ionicons } from '@expo/vector-icons'; instead of.. import Ionicons from 'react-native-vector-icons/Ionicons';.

giautm commented 7 years ago

@sabativi : So, is that PR unnecessary?