search

esbenp / react-native-clean-form

Easy react-native forms using bootstrap-like syntax with redux-form+immutablejs integration. Styled using styled-components
http://esbenp.github.io/2017/01/06/react-native-redux-form-immutable-styled-components/
MIT License
478 stars 83 forks source link

Migrate to @expo/vector-icons #42

Closed giautm closed 7 years ago

giautm commented 7 years ago

Pull request for https://github.com/esbenp/react-native-clean-form/issues/41

markusguenther commented 7 years ago

Hi,

thank you for the feedback and the pull request. Not everybody is using expo and so the dependency to the expo package does not make anything better.

I guess to have the more modular, we can provide the icons as attribute and then the enduser can decide what kind of icon should be used.

What do you think. Then all can decide what kind of package they will use. Only the example app will have the dependency then. But that is not that important.

Greets and happy eastern :)

giautm commented 7 years ago

Agree.

I think we need to extract arrow-down icon from vector-icons for the Select component. And implement some things like renderLeftIcon and renderRightIcon for the Button component, this will be a breaking changes because there is no props icon.

Ps: I know this repo because it is mentioned in the Expo's slack channel. haha.

markusguenther commented 7 years ago

New properties are breaking of course. But making this flexible is worth it. But pay this with another dependency should not the way so the icon property would be nice.

If I find some time I will add this.