search

esbenp / react-native-clean-form

Easy react-native forms using bootstrap-like syntax with redux-form+immutablejs integration. Styled using styled-components
http://esbenp.github.io/2017/01/06/react-native-redux-form-immutable-styled-components/
MIT License
478 stars 76 forks source link

Replaced React.PropTypes with PropTypes from the prop-types package #69

Closed jdcc2 closed 6 years ago

jdcc2 commented 6 years ago

Replaced React.PropTypes with PropTypes from the prop-types package to support React 16 and higher

aschmid commented 6 years ago

@jdcc2 you forgot to update to PropTypes in redux-form/createInputCreator.js. let me know if you want me to update it or you can do it and let me know when done.

jdcc2 commented 6 years ago

@aschmid Go ahead and change it if you want. I just changed the PropTypes to get it working and see what the components looked like. I am not using this right now.

leoskyrocker commented 6 years ago

I tried to merge this into OP's fork, but haven't heard back, so I created a new PR (https://github.com/esbenp/react-native-clean-form/pull/71) to merge into esbenp/react-native-clean-form.

@aschmid Seems like I got no permission to assign you as the reviewer, so I'm notifying you here.