search

esbtools / esb-message-admin

GNU General Public License v3.0
5 stars 9 forks source link

Remove dao layer #142

Closed derek63 closed 8 years ago

derek63 commented 9 years ago

I know that EsbMessageAdminServiceImpl is now huge, however we can that in a future refactoring

derek63 commented 9 years ago

@alechenninger ready for review

alechenninger commented 9 years ago

Overall goal of the refactor is accomplished. I like some of the stuff you did with configuration, though IMHO I have generally found using an instance of an interface universally better than a static API. There are definitely some weird things that already existed in the previous "DAO" class implementations that haven't gone away, but I restrained myself from attacking that just yet :).