search

esbtools / esb-message-admin

GNU General Public License v3.0
5 stars 9 forks source link

Combine ErrorDetailsCtrl and ErrorsSearchCtrl? #37

Closed alechenninger closed 8 years ago

alechenninger commented 9 years ago

Right now the details controller just exists for two reasons:

  1. Update $scope.message on scope when $rootScope.selectedMessage changes.
  2. Provide a resubmitMessage method on scope.

I think this should just be merged into the search controller because:

  1. The search controller is already watching $scope.messageSelections in order to set $rootScope.selectedMessage. This intermediate step could be skipped and the selected message details could be retrieved / set here for the details view to look at directly.
  2. Explicitly using $rootScope to pass data between controllers is not a best practice (kind of hinted at in Angular FAQ)
  3. I know @derek63 already ran into some confusion with the two controllers on the same page, and it might just make things easier to only deal with one controller at the top level for this page.