search

esbtools / event-handler

Notification in, document out.
GNU General Public License v3.0
3 stars 6 forks source link

Issue #74 : Remove locking from LightblueNotificationRepository #79

Closed svkm102 closed 7 years ago

svkm102 commented 7 years ago

74

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.4%) to 60.141% when pulling c687027008bb40e03100884db565c84a86be5383 on svkm102:remove-notificationrepo-locking into 03a3f42821d3caa09e3746b0f3e30321cd38e35b on esbtools:master.

svkm102 commented 7 years ago

The removal of locking has resulted in one of the test cases(shouldRetrieveNonOverlappingSetsOfNotificationsIfCalledByMultipleThreads in LightblueNotificationRepositoryTest ) becoming inconsistent in its results and it passes and fails at random. Tried fixing with thread sleep and while that seems to be working on local, its breaking on travis-ci build. If the code changes are inline with expectations, we may have to ignore this particular test for successful travis-ci build.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 61.189% when pulling 67332d147a61458382ff3345f0b36c9cf4343b48 on svkm102:remove-notificationrepo-locking into 03a3f42821d3caa09e3746b0f3e30321cd38e35b on esbtools:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 61.189% when pulling 67332d147a61458382ff3345f0b36c9cf4343b48 on svkm102:remove-notificationrepo-locking into 03a3f42821d3caa09e3746b0f3e30321cd38e35b on esbtools:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 61.189% when pulling 213430eca7b559e9bfacc097d553235f78a72a41 on svkm102:remove-notificationrepo-locking into 03a3f42821d3caa09e3746b0f3e30321cd38e35b on esbtools:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 59.783% when pulling 6efe95bb9fb6c9b1ee730fb8d3279425cbab65bc on svkm102:remove-notificationrepo-locking into 4b4b52f8fb0e6f807ccfb8e55b1c8f9c7bc7d213 on esbtools:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.9%) to 61.189% when pulling 3b0f4b79889f0078d4a46aeccd885c57ed0e0045 on svkm102:remove-notificationrepo-locking into 4b4b52f8fb0e6f807ccfb8e55b1c8f9c7bc7d213 on esbtools:master.