search

esbullington / react-d3

Modular React charts made with d3.js
https://reactiva.github.io/react-d3-website/
MIT License
1.75k stars 179 forks source link

Added VennDiagram #301

Closed tyfoo closed 8 years ago

tyfoo commented 8 years ago

Added a VennDiagram using venn.js (see http://www.benfrederickson.com/venn-diagrams-with-d3.js/ for more details)

yang-wei commented 8 years ago

This is great but I don't think it's the requirement for most case in building chart. So I would choose to avoid adding another layer of dependency into this library.

Anyway thanks !

tyfoo commented 8 years ago

Thanks for the quick feedback.

I understand. Would you like me to do a version without the venn.js dependency?

yang-wei commented 8 years ago

understand. Would you like me to do a version without the venn.js dependency?

that would be awesome !

tyfoo commented 8 years ago

@yang-wei please see amended commit without the venn.js dependency.

I've taken the functions used from venn.js and put them under venn.js folder, including credit to @benfred and the original library / blog post. I hope that is okay.

MatthewHerbst commented 8 years ago

@yang-wei I would say based on how much code is copy/pasted from venn.js, just use the dependency. There is no reason to duplicate code, and, none of us are going to spend as much time maintaining and improving that code as the original author.