Closed tasn closed 10 years ago
@tasn I'll check what is going on with Ember 1.8. Opss, most tests are failing :/
Thanks. Very annoying that they break API. I wonder if it's maybe worth it to take a look at 1.9alpha (or is it beta?) too.
There are many problems with the current tests under Ember.1.8.0. Maybe we need to upgrade ember-data as well to be able to work with 1.8.0.
We'll have a look. Thanks for catching it!
Ember 1.8 needs ember-data 11, didn't test it with ember-data 10.
Updating to that version all tests pass, well, except test number 6 - which is just mind boggling, it's a simple save call, shouldn't lead to an infinite loop...
@tasn I've made most of the changes necessary for ember-data beta 11 on PR #48, I needs a few more tests, but if you could test it and reviewed it would be awesome. It should work with Ember 1.8.
Looking at the stack trace from the failing test the error does not seem to be raised from the adapter code. I'd say Ember 1.8.0 and ED beta8 are incompatible
Source:
TypeError: undefined is not a function
at Object.func (http://localhost:7357/bower_components/ember/ember.js:17100:72)
at Object.Cache.get (http://localhost:7357/bower_components/ember/ember.js:11926:38)
at isPath (http://localhost:7357/bower_components/ember/ember.js:17122:26)
at get (http://localhost:7357/bower_components/ember/ember.js:17891:33)
at http://localhost:7357/tests/ember_configuration.js:100:20
at Ember.Object.extend.serializeAttribute (http://localhost:7357/bower_components/ember-data/ember-data.js:2834:21)
at null.<anonymous> (http://localhost:7357/bower_components/ember-data/ember-data.js:2795:16)
at null.<anonymous> (http://localhost:7357/bower_components/ember-data/ember-data.js:5459:20)
at cb (http://localhost:7357/bower_components/ember/ember.js:15908:22)
at OrderedSet.forEach (http://localhost:7357/bower_components/ember/ember.js:15706:13)
@escalant3 I had errors from the adapter code. It's possible that I've tried that with beta11, I honestly don't remember anymore.
@pedrokiefer I'll try with your pull request and let you know. My usage is very limited, so I'm not sure how much of a "real life" test case it'll be.
@pedrokiefer Works great. However in my test case I only get data, never save, so I wouldn't have triggered your save() bug.
Edit: ember 1.8.1, ember-data 1.0.0-beta.11 and the version from your beta11 branch.
Anyhow, I guess we can close this one, because it's a dupe of #46.
Upgrading to Ember 1.8 makes things fail (in the decamelize attribute function).
If you can't reproduce using one of the test cases you have, let me know, I'll try to get a working test case going.
Thanks a lot for your great work.