search

escalate / hugo-split-theme

Port of Split template by One Page Love to Hugo
https://themes.gohugo.io/themes/hugo-split-theme/
Other
76 stars 89 forks source link

Don't link to Google Fonts directly #22

Closed afoeder closed 6 months ago

afoeder commented 1 year ago

The CSS deeplinks/imports the Google Fonts directly from Google, see both

https://github.com/escalate/hugo-split-theme/blob/bc49ceb2cc29d4979906a3a0b82e65da131a51a1/static/assets/sass/01-content.scss#L5-L6

https://github.com/escalate/hugo-split-theme/blob/bc49ceb2cc29d4979906a3a0b82e65da131a51a1/static/assets/css/split.css#L9-L10

This is at least in GDPR countries unfortunately and completely stupidly not a good thing anymore and led to adhortatory letters (🇩🇪 "Abmahnungen"). I also accidentally almost published the site. I think it makes sense to locally copy the fonts to this project and serve them from here.

I could take care, however some thoughts about how the crediting, mentioning should look like to be sufficient would be nice. Does it have to be present at the footer line?

escalate commented 1 year ago

Hello @afoeder,

you are welcome to submit an MR for implementation.

Best regards Felix

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: