escamero / mirlyn

11 stars 3 forks source link

Issue with mirl() in v1.4.1 #9

Closed cckeneally closed 1 year ago

cckeneally commented 1 year ago

Hi,

First of all, this is a great package! Thank you very much.

Since the recent update of mirl() to V1.4.1, I am not able to run phyloseq objects as x in the function. Using the example data from mirlyn:

data("example") example

phyloseq-class experiment-level object otu_table() OTU Table: [ 3342 taxa and 6 samples ] sample_data() Sample Data: [ 6 samples by 1 sample variables ] tax_table() Taxonomy Table: [ 3342 taxa by 7 taxonomic ranks ] phy_tree() Phylogenetic Tree: [ 3342 tips and 3336 internal nodes ]

mirlps <- mirl(example, rep = 5)

Error in if (ncol(x) > ncol(mirlobj[[1]])) { : argument is of length zero

It seems to work fine with just an otu table, but I'm no longer able to run mirl() on a phyloseq object.

bjmt commented 1 year ago

My apologies!! Looks like I broke the package after the last update. I've fixed the bug and made another version change (v1.4.2). Let me know if it's working now.

cckeneally commented 1 year ago

Fantastic! Working again for me. Thanks for your help.