search

escaped / django-video-encoding

django-video-encoding helps to convert your videos into different formats and resolutions.
BSD 3-Clause "New" or "Revised" License
115 stars 45 forks source link

#1 Fixed: Upload VideoField on Admin and Migration of object_id to text_field #2

Closed iraycd closed 6 months ago

iraycd commented 7 years ago

@escaped I have changed few changes which are important. Instead of object_id being a IntegerField it's now TextField as it should support UUID if that's the primary key.

The test breaks as it's using Django 1.8. I am using Django 1.11

escaped commented 7 years ago

@iraycd Thanks a lot for the PR. I really looking forward to it :) Since you are still adding commits and the tests are failing, i assume that you keep working on it. Please drop me a message if you are ready or need further help. Then i'll do a code review :)

Please make your changes compatible with django>1.7. You can use the provided .tox configuration. Just run the following commands:

pip install tox
tox

It will run the test Suite against Python 2.7/3.5/3.6 and all django version 1.8-1.10. I don't know if the current codebase is compatible with 1.11. But feel free to add that to the configuration.

escaped commented 6 years ago

hey @iraycd, i finally looked into your changes, even though the tests are not working. Your PR seems to contain two independent features:

  1. Add support for the django admin using a FileField instead of an ImageField (#1)
  2. Change the ForeignKey on Format to TextField. (i am not sure, if i like that change. But it seems reasonable).

Could you please split your PR into two seperate PRs. Than i'll have another look.

Thanks a lot :)