escapingnetwork / core-keeper-dedicated

Dockerfile for automated build of a Core Keeper Dedicated Server
https://hub.docker.com/r/escaping/core-keeper-dedicated
MIT License
121 stars 36 forks source link

Unable to get any halloween items. #65

Closed IcelandicIcecream closed 2 weeks ago

IcelandicIcecream commented 1 month ago

Any halloween items can be picked up but it doesn't show up in my inventory. Not sure whether it has anything to do with the server but just putting this out here.

Diyagi commented 1 month ago

This usually happens when you set your game season to halloween but not the server. Oops, forgot its halloween, its not a thing in my country lol

EmberKnight commented 1 month ago

I have the same issue as well. The parameter value -1 for seasons doesn't work as described in the README. -1 is default setting where it is set depending on system date.

According to the wiki -1 is None https://core-keeper.fandom.com/wiki/Server_Config

When setting the value to the actual season (e.g. 2 for Halloween) it works without a problem.

Something seems off here

Micke90s commented 1 month ago

@EmberKnight Are you sure? I would guess that the wiki is outdated.

The seasons are defined as Enum. This should start at 0. So the README should be correct: image (Source Pug.Base.dll)

EmberKnight commented 1 month ago

@Micke90s this is from the README

https://github.com/escapingnetwork/core-keeper-dedicated

SEASON Overrides current season by setting to any of None (0), Easter (1), Halloween (2), Christmas (3), Valentine (4), Anniversary (5), CherryBlossom (6), LunarNewYear(7). -1 is default setting where it is set depending on system date.

Micke90s commented 1 month ago

SEASON Overrides current season by setting to any of None (0), Easter (1), Halloween (2), Christmas (3), Valentine (4), Anniversary (5), CherryBlossom (6), LunarNewYear(7). -1 is default setting where it is set depending on system date.

Yes, this is a copy of the official READMEwhich is part of the DedicatedServer and this should be correct.

I just tried it and you are correct and it did not work. I don’t think that the value of -1 is wrong. I rather believe that there is a problem on the supply of the value. May the value -1 is handled as a parameter which would cause that the parameter -season to get the value `. This may could be parsed as0`.

Micke90s commented 1 month ago

I think I found the problem. Season -1 must not be supplied. Based on the log of my server Forcing season -1 it should be the following problem. image If the -season parameter is present the DedicatedServer will not call CalculateSeason which seems to cause the same behaviour as None.

EmberKnight commented 4 weeks ago

So just leaving Season variable empty or just omitting it altogether would work?

Micke90s commented 4 weeks ago

Technical it is a bug in the DedicatedServer application which we use. I will open a bug report on @Pugstorm webpage. I just verified this on my local system. (Windows host)

@arguser May we should remove the default values as these values should be set by the DedicatedServer itself. Maybe @Diyagi could add this to #62. So, the problem only would occur if the -season parameter is set in the environment variables.

IcelandicIcecream commented 4 weeks ago

So just leaving Season variable empty or just omitting it altogether would work?

You need to explicitly set it at halloween for it work. omitting doesn't work, not sure if having empty works but i'm assuming it doesn't

Diyagi commented 4 weeks ago

Technical it is a bug in the DedicatedServer application which we use. I will open a bug report on @Pugstorm webpage. I just verified this on my local system. (Windows host)

@arguser May we should remove the default values as these values should be set by the DedicatedServer itself. Maybe @Diyagi could add this to #62. So, the problem only would occur if the -season parameter is set in the environment variables.

Already did

So just leaving Season variable empty or just omitting it altogether would work?

You need to explicitly set it at halloween for it work. omitting doesn't work, not sure if having empty works but i'm assuming it doesn't

Setting it to SEASON="" should work if [ ! -z "${SEASON}" ]; then params=( "${params[@]}" -season "${SEASON}" ); fi

Micke90s commented 4 weeks ago

@Diyagi Thank you. I missed that. I thought the default value was still -1