search

eschanet / simplify

Create and validate simplified likelihoods from full likelihoods.
BSD 3-Clause "New" or "Revised" License
6 stars 2 forks source link

ci: Migrate linting to separate GitHub Actions workflow #11

Closed matthewfeickert closed 3 years ago

matthewfeickert commented 3 years ago

At the moment the linting of the code base runs in the same GitHub Actions workflow as the tests before the tests, which means that if the linting fails for any reason then the tests never run, making it harder to know if a PR should be merged or not. This PR migrates the linting out to a separate workflow that runs on PRs and on workflow dispatch through manual triggers.

As a good example of why this is useful, this PR will fail the linting workflow given that there are current mypy errors, but the tests will could pass. :+1:

Suggested squash and merge commit message:

* Migrate linting out of CI workflow and into a separate GitHub Actions workflow
* Split flake8 checks out between simplify src and the entire codebase
matthewfeickert commented 3 years ago

@eschanet This is ready for review, as fixing tests is outside the scope of this PR.

eschanet commented 3 years ago

LGTM. Sorry for being so slow on this!

matthewfeickert commented 3 years ago

LGTM. Sorry for being so slow on this!

No worries. Congratulations on your Ph.D. as well! :tada: