search

eschava / broadlink-mqtt

MQTT client to control BroadLink devices
MIT License
222 stars 60 forks source link

Adding multiple RM3 abilities using the mac address of each device. #19

Closed psyciknz closed 7 years ago

psyciknz commented 7 years ago

The only conflicts i can see are related to the receiving of temperatures. You'll see I've added a getdevices (as opposed to getdevice) which returns an array. And this array is used by on_message to select mutliple devices based on a : stripped mac address.

eschava commented 7 years ago

Thanks for your pull request! Unfortunately, it has a lot of changes related to your custom configuration so I cannot apply it as is But I definitely will rely on it during implementation of the same functionality

psyciknz commented 7 years ago

Yeah I wondered about that. Also I don't think I'd done it in a particularly good way. I'll keep an eye out for when you push a change out and possibly switch back to your fork.

From: Eugene Schava notifications@github.com Sent: Tuesday, August 22, 2017 2:27:38 AM To: eschava/broadlink-mqtt Cc: psyciknz; Author Subject: Re: [eschava/broadlink-mqtt] Adding multiple RM3 abilities using the mac address of each device. (#19)

Thanks for your pull request! Unfortunately, it has a lot of changes related to your custom configuration so I cannot apply it as is But I definitely will rely on it during implementation of the same functionality

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/eschava/broadlink-mqtt/pull/19#issuecomment-323756580, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFGkczZdiO2zUYjUGNafBqF5dHFf2hDlks5saZPZgaJpZM4O3ZjT.