search

eschava / broadlink-mqtt

MQTT client to control BroadLink devices
MIT License
222 stars 61 forks source link

hi, #5

Closed hamwong closed 7 years ago

hamwong commented 7 years ago

can you add exception at code for time out? so code can keep running once there is time out

[2017-02-26 18:00:37,667] DEBUG Sending RM temperature 19.8 to topic broadlink/temperature [2017-02-26 18:04:37,851] DEBUG Sending RM temperature 19.6 to topic broadlink/temperature [2017-02-26 18:08:38,792] ERROR Error Traceback (most recent call last): File "/home/pi/broadlink-mqtt/mqtt.py", line 197, in run self.scheduler.run() File "/usr/lib/python2.7/sched.py", line 117, in run action(*argument) File "/home/pi/broadlink-mqtt/mqtt.py", line 184, in broadlink_rm_temperature_timer temperature = str(device.check_temperature()) File "/usr/local/lib/python2.7/dist-packages/broadlink-0.3-py2.7.egg/broadlink/init.py", line 569, in check_temperature response = self.send_packet(0x6a, packet) File "/usr/local/lib/python2.7/dist-packages/broadlink-0.3-py2.7.egg/broadlink/init.py", line 342, in send_packet response = self.cs.recvfrom(1024) timeout: timed out

Code than stopped here, but actually it still running on background [20:00:45] pi@openHABianPi:~$ ps aux | grep mqtt pi 8470 0.0 0.1 5888 1948 pts/2 S+ 20:00 0:00 grep --color=auto mqtt pi 24833 0.0 1.0 25152 10524 pts/2 S 09:20 0:10 python /home/pi/broadlink-mqtt/mqtt.py

eschava commented 7 years ago

Done Thanks for feedback!

hamwong commented 7 years ago

Thanks, I just update the code, and will do it on a long run see will any issue come up, Thanks for your hard works.

hamwong commented 7 years ago

still the same

[2017-03-02 04:36:26,694] DEBUG Sending RM temperature 23.0 to topic broadlink/temperature [2017-03-02 04:40:27,742] ERROR Error Traceback (most recent call last): File "/home/pi/broadlink-mqtt/mqtt.py", line 197, in run self.scheduler.run() File "/usr/lib/python2.7/sched.py", line 117, in run action(*argument) File "/home/pi/broadlink-mqtt/mqtt.py", line 184, in broadlink_rm_temperature_timer temperature = str(device.check_temperature()) File "/usr/local/lib/python2.7/dist-packages/broadlink-0.3-py2.7.egg/broadlink/init.py", line 569, in check_temperature response = self.send_packet(0x6a, packet) File "/usr/local/lib/python2.7/dist-packages/broadlink-0.3-py2.7.egg/broadlink/init.py", line 342, in send_packet response = self.cs.recvfrom(1024) timeout: timed out

eschava commented 7 years ago

Hi,

for some reason I have different line numbers Is there any local changes in your version?

hamwong commented 7 years ago

I only add one more line in line 165 and modify few line after, but that only for work with another branch of broadlink library name = (cf.get('device_name')) if device_type == 'rm': return broadlink.rm(host=host, mac=mac, name=name) elif device_type == 'sp1': return broadlink.sp1(host=host, mac=mac, name=name) elif device_type == 'sp2': return broadlink.sp2(host=host, mac=mac, name=name) elif device_type == 'a1': return broadlink.a1(host=host, mac=mac, name=name) elif device_type == 'mp1': return broadlink.mp1(host=host, mac=mac, name=name)

eschava commented 7 years ago

Found and fixed Thank you!

hamwong commented 7 years ago

Thank you for all you did, I will do a long run test agian

hamwong commented 7 years ago

I think no issue so far, Thank you, it's excellent