eschercloudai / unikorn

Magical Cloud Automation
https://eschercloud.ai
Apache License 2.0
5 stars 0 forks source link

Honour explicit requests to not install the NVIDIA GPU Operator #335

Closed yankcrime closed 1 year ago

yankcrime commented 1 year ago

Right now, Unikorn Server's decision as to whether to install the Operator or not is final as far as the resulting Kubernetes cluster spec is concerned, based on whether GPUs are detected in any workload pools.

This change checks for an explicit disabling of said Operator in the creation request, and if set does not install regardless of whether GPUs are available.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@66329b8). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #335   +/-   ##
=======================================
  Coverage        ?   46.73%           
=======================================
  Files           ?       73           
  Lines           ?    10025           
  Branches        ?        0           
=======================================
  Hits            ?     4685           
  Misses          ?     4812           
  Partials        ?      528           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more