codecov[bot]
commented
1 year ago Codecov Report
Merging #343 (985ee44) into main (04cea22) will increase coverage by
0.13%. The diff coverage is61.44%.:exclamation: Current head 985ee44 differs from pull request most recent head a7a83d4. Consider uploading reports for the commit a7a83d4 to get more accurate results
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 46.72% 46.85% +0.13%
==========================================
Files 73 74 +1
Lines 10066 10133 +67
==========================================
+ Hits 4703 4748 +45
- Misses 4827 4847 +20
- Partials 536 538 +2 | Files | Coverage Δ | |
|---|---|---|
| pkg/managers/common/reconcile.go | 76.74% <100.00%> (ø) |
|
| pkg/provisioners/application/provisioner.go | 79.60% <100.00%> (+0.52%) |
:arrow_up: |
| pkg/util/mock/interfaces.go | 100.00% <100.00%> (ø) |
|
| ...s/helmapplications/clusteropenstack/provisioner.go | 0.00% <0.00%> (ø) |
|
| pkg/util/util.go | 13.46% <0.00%> (-5.46%) |
:arrow_down: |
| pkg/cd/argocd/driver.go | 73.87% <60.00%> (-1.13%) |
:arrow_down: |
... and 1 file with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
Argo will have a flap if you create a remote and it cannot talk to it, stalling for like 5 minutes until it retires the conection, so perform this check for it to avoid the timeout, much like how it would work if created via the API. Secondly, there's a quick hack to allow continued provisioning while certain applications are degraded i.e. working, but not fully. Also, sneak in a change to CAPO to prevent it doing "clever" scheduling choices, when Nova is actually more cleverer in this instance.