search

eschercloudai / unikorn

Magical Cloud Automation
https://eschercloud.ai
Apache License 2.0
5 stars 0 forks source link

Limit Implicit Resource Creation #362

Closed spjmurray closed 10 months ago

spjmurray commented 10 months ago

It seems a bit odd if getting a CL from a non-existent CP causes the creation of the latter. In fact I've hit this many a time in the UI. Only allow creation if the operation causing it is a creation itself.

Fixes #308

codecov[bot] commented 10 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (aeff0ad) 54.70% compared to head (2c27e6e) 54.75%.

:exclamation: Current head 2c27e6e differs from pull request most recent head e552338. Consider uploading reports for the commit e552338 to get more accurate results

Files Patch % Lines
pkg/server/handler/controlplane/client.go 75.00% 4 Missing and 2 partials :warning:
pkg/server/handler/project/client.go 68.42% 4 Missing and 2 partials :warning:
pkg/server/handler/cluster/client.go 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================== + Coverage 54.70% 54.75% +0.05% ========================================== Files 66 66 Lines 5744 5777 +33 ========================================== + Hits 3142 3163 +21 - Misses 2306 2314 +8 - Partials 296 300 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

spjmurray commented 10 months ago

Amazing, you deserve a bonus and pay rise 👍🏻