eschnett / ADIOS2.jl

A Julia interface to ADIOS2
MIT License
13 stars 6 forks source link

Warning for non-MPI adios2 back end turns into error #14

Closed williamfgc closed 1 year ago

williamfgc commented 1 year ago

The warning here turns into an error with message warning is not defined

pkg> build
    Building ADIOS2 → `~/.julia/scratchspaces/44cfe95a-1eb2-52ea-b672-e2afdf69b78f/7d6cb2edab30b0bd6fd17108a11f6c2883ff5d08/build.log`
ERROR: Error building `ADIOS2`: 
[ Info: using system ADIOS2
ERROR: LoadError: UndefVarError: `warning` not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/ADIOS2/yWfNU/deps/build.jl:54
 [2] include(fname::String)
   @ Base.MainInclude ./client.jl:478
 [3] top-level scope
   @ none:5
in expression starting at /home/wfg/.julia/packages/ADIOS2/yWfNU/deps/build.jl:34
eschnett commented 1 year ago

It turns out that we have to handle https://github.com/JuliaPackaging/Yggdrasil/pull/6932 first...

eschnett commented 1 year ago

(I have a patch for your problem; replacing warning by @info should do the trick.)

eschnett commented 1 year ago

Will be closed by https://github.com/JuliaRegistries/General/pull/86161.