eschnett / zotero-citationcounts

Zotero plugin for auto-fetching citation counts from various sources
Mozilla Public License 2.0
781 stars 35 forks source link

Crashes Zotero when adding items #26

Open champagnealexandre opened 2 years ago

champagnealexandre commented 2 years ago

Hi,

The citationcounts plugin crashes Zotero when used with some other plugins at the same time.

See issue opened in the repo of one of those plugins: https://github.com/windingwind/zotero-tag/issues/36

I have also posted a discussion on the Zotero forum here: https://forums.zotero.org/discussion/99865/plugins-causing-segmentation-fault-when-used-together-citation-counts-manager-zotero-tag?new=1

Any idea what might be causing this?

Thanks.

retorquere commented 2 years ago

Removing this line may help. The Zotero object is already loaded in the overlay, and there seems to be a problem when it's reloaded when already available.

champagnealexandre commented 2 years ago

Thanks @retorquere ; I’m not familiar with Zotero plugin development so I can’t build/test but I hope @eschnett will take that into account.

pencilheart commented 2 years ago

Removing this line may help. The Zotero object is already loaded in the overlay, and there seems to be a problem when it's reloaded when already available.

It doesn't work. The modified .xpi can't be installed (show below). The add-on "%S" could not be installed. It may be incompatible with this version of Zotero.

retorquere commented 2 years ago

That's zotero's way of telling you the xpi you have is not a zip file. If you changed the xpi, you haven't put it back together right.

pencilheart commented 2 years ago

@retorquere Thank you. You're right. It works when I "select the files and folders at root level and zip from here" instead of "zip from outside the plugin folder".

@champagnealexandre Here are the steps. https://github.com/eschnett/zotero-citationcounts/issues/17#issuecomment-1073409781

champagnealexandre commented 2 years ago

@pencilheart worked perfectly, thank you! Thanks @retorquere too for your help.

champagnealexandre commented 2 years ago

Hmm, for some reason the first article I added after doing the modification @retorquere suggested was added correctly, but now I’ve just added a second article and Zotero crashed again. Disabling again the plugin and no more crashes..

pencilheart commented 2 years ago

me too....