eschnou / storytlr

Storytlr is an opensource lifestreaming and microblogging platform written in PHP. Note: The default branch (master) is the development branch, if you need a stable version, see the release-XX branches, tags, or downloads.

http://storytlr.org

Other

216 stars 57 forks source link

FIX setcookie when a custom http port is used #83

Closed Simounet closed 10 years ago

Simounet commented 10 years ago

Use case without this patch:

Install Storytlr from http://storytlr.loc:8080/
Try to login with the same url
No error displayed => It's not possible to set a cookie with a port number in the cookie domain
Patch:
Use parse_url PHP function
Check if there is a custom http port
if true: just get the host and let the port behind
if false: return the initial string

eschnou commented 10 years ago

Thanks! Great to see someone showing some love for good old storytlr :-)

Simounet commented 10 years ago

You're welcome. It's seems like a great product. I tried to used it but I couldn't login until now. Storytlr, here I come! Are you always working on it?

ps: Is Stuffpress a library from you or do I have to fix it somewhere else?

eschnou commented 10 years ago

I'm actively using it on my own site: https://eschnou.com, and doing just basic maintenance based on my needs. There are a few other users out there just happy with it as it is today.

Stuffpress was the name of Stotytlr a loong time ago and I kept the name as is in the internals.

Simounet commented 10 years ago

Good to know. Thanks for these advises and I hope to be a new Storytlr user.

eschnou / storytlr

FIX setcookie when a custom http port is used #83

Use case without this patch:

Patch: