eschnou / storytlr

Storytlr is an opensource lifestreaming and microblogging platform written in PHP. Note: The default branch (master) is the development branch, if you need a stable version, see the release-XX branches, tags, or downloads.
http://storytlr.org
Other
216 stars 57 forks source link

Import Souncloud tracks uploaded date and tags #84

Open Simounet opened 10 years ago

Simounet commented 10 years ago
eschnou commented 10 years ago

Thanks for your continued contributions :-)

I have an issue with this one: the soundcloud plugin currently only imports the user favorites (this can probably be easily extended to uploaded tracks as well). For favorites, I want the entry to be in my stream at the date/time when I favorited it, not when the track got uploaded (could have been years ago).

So, your fix would be the correct behavior for user uploaded tracks, but I don't like this behavior for favorites. What do you think? What use case did you have in mind?

Simounet commented 10 years ago

I agree. My next move will be to import our own tracks but I'll try to get the fav' date for favs before.

Simounet commented 10 years ago

Hewww, it doesn't seem to be possible atm: http://stackoverflow.com/a/20856588/2550448 . I've send a mail to the Soundcloud's API guys. I'll see if I can get a reply about this feature. In the mean time, can I split this PR with the tags feature, if it looks ok for you?

eschnou commented 10 years ago

Sure!

Aboute the date, I don't think it is too much an issue. My update cron job runs every five minutes. So, worst case is I'm off 5 minutes :-) The issue is when importing the feed the first time. So, one solution would be:

Simounet commented 10 years ago

Hi Laurent, Time is passing by too fast... I made a patch and removed the created_at date handling. It's just for the tags' impot now.