search

eschulte / emacs-web-server

web server running Emacs Lisp handlers.
eschulte.github.io/emacs-web-server/index.html#Top
GNU General Public License v3.0
173 stars 30 forks source link

Fix function names without package prefix #15

Closed xuchunyang closed 4 years ago

xuchunyang commented 4 years ago

For #13.

A github workflow is also added to run the byte compile & tests, so we can ensure the PR does not break the existing code. Lexical binding is also enabled by the way #14.

xuchunyang commented 4 years ago

A github workflow is also added to run the byte compile & tests, so we can ensure the PR does not break the existing code

It runs successfully according to https://github.com/xuchunyang/emacs-web-server/actions?query=workflow%3ACI

I have also tested the new code with a simple web app, and the result is good.

xuchunyang commented 4 years ago

I just notice this package is on gnu elpa as well. I should mention that I've signed the fsf copyright assignment for the gnu emacs project.

xuchunyang commented 4 years ago

Closing as you've fixed the issue.

eschulte commented 4 years ago

Sorry, I didn't notice this before I pushed my change. Is there anything in this PR which should be included? It looks like you did some good CI/testing work as well.

eschulte commented 4 years ago

Okay, I've brought in your CI changes from this PR into the master branch. This is great, Thanks!