Add evil-mode keybindings to epresent-mode-map

eschulte / epresent

Presentations in Emacs -- based on Org-mode

183 stars 51 forks source link

Add evil-mode keybindings to epresent-mode-map #67

Closed cwinsnes closed 2 years ago

cwinsnes commented 4 years ago

Add evil-mode keybindings to the epresent-modemap:

Binds the same keys as the normal epresent + h/l for next/previous page respectively.
Binds the keys only in evil-normal-state.
Forces evil-normal-state on epresent-run

Uncertain if this is the idiomatic evil-mode way of doing it but it seems to work.

MTRNord commented 3 years ago

This fails with spacmacs with this error:

helm-M-x-execute-command: Invalid function: evil-define-key

cwinsnes commented 3 years ago

That sounds like a Spacemacs problem to me. Using vanilla emacs 27.1 + evil installed from melpa, there is a function called evil-define-key defined in evil-core.el. It's not available interactively.

It's defined as (evil-define-key STATE KEYMAP KEY DEF &rest BINDINGS)

I haven't used epresent in quite some time so I will probably not spend the time to try to solve the issue for Spacemacs.

eschulte commented 2 years ago

Sorry I didn't take the time to address this earlier. The change set looks purely additive with very little risk to apply, so I'm going to reopen and apply.