small bug-fix to split string properly in `run-ruby'

[lewang]

I use cygwin tools, and cygwin Ruby 1.9 in a native build windows of Emacs. So I have use a string that contains a quoted string in to eventually call run-ruby like this:

(run-ruby "sh -c \"irb --inf-ruby-mode -r irb/completion\"" "ruby")

this patch calls split-string-and-unquote to parse the string properly. It should not break anything else where. I can't imagine a context where it's better to always split on space.

[purcell]

inf-ruby.el is actually part of ruby-mode, not rinari: http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/misc/

Sorry for the confusion. I will see what I can do about removing ruby-mode.el and inf-ruby.el from rinari.

-Steve

[lewang]

I see. Thanks for the timely response. In the end I went with a windows batch file to solve my problem anyway.

[purcell]

It looks like the inf-ruby.el in the ruby-mode source tree is quite different from the one that was bundled with rinari; I didn't find that same use of "string-split", so it might be that the problem got fixed independently.

[lewang]

I just looked at those files at http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/misc/ . They are very old. Can you track down where the files in rinari came from? Removing them may break rinari for some people.

[purcell]

Are you sure they're old? The timestamp at the top of my "inf-ruby.el" from "http://svn.ruby-lang.org/repos/ruby/trunk/misc/" is:

;;; $Id: inf-ruby.el 30505 2011-01-10 04:51:20Z nobu $ ;;; $Author: nobu $

so that looks more recent than Rinari's file, right?

I agree that the "History" sections in the files look old, but perhaps they simply haven't been updated.

I've been using the .el files from svn instead of the rinari ones for a long time now without problems.

-Steve

On 1 Sep 2011, at 18:23, lewang wrote:

I just looked at those files at http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/misc/ . They are very old. Can you track down where the files in rinari came from? Removing them may break rinari for some people.

Reply to this email directly or view it on GitHub: https://github.com/eschulte/rinari/pull/14#issuecomment-1970411

[lewang]

Only looking at inf-ruby, the version in rinari mentions eshulte, maybe he's forked it. It also supports other Ruby implementations which I wouldn't expect misc/inf-ruby.el.

[lewang]

I see that both ruby-mode.el and inf-ruby.el have been forked before eschulte took over. See https://github.com/technomancy/rinari/commits/master/util/inf-ruby.el Maybe you should restore them and update the header so people aren't confused in future? and start accepting changes? :)

[purcell]

Okay, I've done some further research.

First, I think we can agree that the ruby-mode.el in rinari is definitely not the best version to use -- there have been multiple changes this year to the version in the ruby-mode SVN repo.

Secondly, you're right that there is value in the forked version of inf-ruby.el. Phil Hagelberg (technomancy) started the fork:

http://groups.google.com/group/emacs-on-rails/browse_thread/thread/ae87fc797822bf3?pli=1

However, the version in ELPA is 2.1.1, which is newer than the version in rinari (2.1):

http://marmalade-repo.org/packages/inf-ruby

That version was packaged by nonsequitur, who appears to have been actively maintaining the lib:

https://github.com/nonsequitur/inf-ruby/commits/master

So in summary, I'll keep ruby-mode.el and inf-ruby.el out of rinari, but I'll make the documentation clear about where to obtain the best versions of those libs.

Hope that makes sense!

-Steve

On 2 Sep 2011, at 06:44, lewang wrote:

I see that both ruby-mode.el and inf-ruby.el have been forked before eschulte took over. See https://github.com/technomancy/rinari/commits/master/util/inf-ruby.el Maybe you should restore them and update the header so people aren't confused in future? and start accepting changes? :)

Reply to this email directly or view it on GitHub: https://github.com/eschulte/rinari/pull/14#issuecomment-1976196

[lewang]

All cleared up.

you = Gentleman.new.extend(Scholar)

Can you leave the link to the updated rinari docs here?

[purcell]

Will do, though I don't have edit access to the current docs on rubyforge, so I'll perhaps have to figure out how to move the docs to github.

-Steve

On 2 Sep 2011, at 11:19, lewang wrote:

All cleared up.

you = Gentleman.new.extend(Scholar)

Can you leave the link to the updated rinari docs here?

Reply to this email directly or view it on GitHub: https://github.com/eschulte/rinari/pull/14#issuecomment-1977854