can not jump spec from view file to spec file

eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)

http://rinari.rubyforge.org

GNU General Public License v3.0

412 stars 68 forks source link

can not jump spec from view file to spec file #27

Closed eiel closed 12 years ago

eiel commented 12 years ago

I Changed the jump spec for views rspec. Non-greedy regexp can match filename in view file.

For example.

viewfile "app/views/tweet.html.erb"
spec "app/\1" -> "app/$.*?$"
- match-string 0 -> "app/"
- match-string 1 -> ""
modify spec "app/\1$" -> "app/$.*?$"
- match-string 0 -> "app/views/tweet.html.erb"
- match-string 1 -> "views/tweet.html.erb"

purcell commented 12 years ago

Thanks for this. I'm just trying to make sure I understand the effects of the patch, and I'm wondering; are the other patterns still correct, e.g. spec/views/\\1_spec.rb etc.?

-Steve

eiel commented 12 years ago

spec/views/\1_spec.rb is no problem.

On a problem, the case where there is no suffix.

It is the following patterns that have the same problem.

app/cells/\1/\2.*
test/unit/\1test.rb#test\2
app/controllers/\1.rb#\2
app/models/\1.rb#\2"
app/controllers/\1_controller.rb#\2

It seems that this problem has occurred by 7982351c873ba2ce9fdf2ff80d0af9f0ffb6d70f of jump.el.

purcell commented 12 years ago

Ah, okay. Could you please push a further commit which changes those patterns too, and then I can merge and release all the changes together?

-Steve

eiel commented 12 years ago

I modified bad pattern.And, I pushed new commit.

Sincerely

purcell commented 12 years ago

Thanks! A new version (2.6) is now tagged and a package has been uploaded to Marmalade-Repo.org. A new snapshot package will be built on Melpa (http://melpa.milkbox.net) shortly.

-Steve