search

eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

rinari still depends on ruby-mode 1.1 #50

Closed dgutov closed 11 years ago

dgutov commented 11 years ago

f25f73ab012a6f5737feecdd75a448471518bb18 removed it from ruby-compilation, but rinari.el still has it in the Package-Requires header.

purcell commented 11 years ago

Yeah, I guess it's not absolutely required, but since the addition of rinari-highlight-keywords, there are still references to variables defined in ruby-mode.

dgutov commented 11 years ago

As far as I can tell, the new highlighting works just as well with ruby-mode 1.0 bundled with Emacs. Isn't that right?

purcell commented 11 years ago

Ah, okay, yes - I see your point. I'll fix it.

Just yesterday I was wondering why I had ruby-mode installed from ELPA, when the version in Emacs HEAD is newer...

purcell commented 11 years ago

If I bump the Package-Requires down to 1.0, it should pick up the built-in ruby-mode, right?

dgutov commented 11 years ago

Thanks, that's much better. :)