search

eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

Variable binding depth exceeds max-specdpl-size #58

Closed dgutov closed 11 years ago

dgutov commented 11 years ago

To reproduce, just evaluate: (browse-url-emacs "http://google.com")

It causes post-command-hook to start failing in global-rinari-mode-check-buffers every time I try to M-x or M-:. Not sure what's the exact problem, maybe you just need to ignore the special and hidden buffers.

purcell commented 11 years ago

Odd. That's the first time I've seen it. There's no obvious problem in the macroexpanded code, and I can't figure out how to get a useful traceback... sigh.

purcell commented 11 years ago

Just spent ages looking into this and haven't managed to figure it out. It doesn't help that the debugger can't be entered from within post-command-hook.

dgutov commented 11 years ago

Eh, found it. Disable global-rinari-mode, evaluate the browse expression, and in the new buffer evaluate (rinari-root). It loops on "http:/".

purcell commented 11 years ago

Ah, well spotted! My brain's not working well enough today to figure out the best fix, but it helps a lot to know where to look. :-)

purcell commented 11 years ago

file-directory-p handles tramp paths etc. nicely, so I've used that to safeguard the code.

dgutov commented 11 years ago

Works fine, thanks!