search

eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

(void-variable compilation-save-buffers-predicate) #59

Closed apiology closed 11 years ago

apiology commented 11 years ago

HI!

I'm trying to install rinari under GNU Emacs 23.4.1.

I get the following error when I run M-x rinari-rake and feed it 'test' in my rails project directory:

Debugger entered--Lisp error: (void-variable compilation-save-buffers-predicate) (save-some-buffers (not compilation-ask-about-save) compilation-save-buffers-predicate) ad-Orig-ruby-compilation-do("rake" ("rake" "test")) (setq ad-return-value (ad-Orig-ruby-compilation-do name cmdlist)) (let ((default-directory ...)) (setq ad-return-value (ad-Orig-ruby-compilation-do name cmdlist)) (rinari-launch)) (let (ad-return-value) (let (...) (setq ad-return-value ...) (rinari-launch)) ad-return-value) ruby-compilation-do("rake" ("rake" "test")) (pop-to-buffer (ruby-compilation-do "rake" (cons ruby-compilation-executable-rake ...))) (let* ((task ...) (rake-args ...)) (pop-to-buffer (ruby-compilation-do "rake" ...))) ad-Orig-ruby-compilation-rake(nil nil nil) (setq ad-return-value (ad-Orig-ruby-compilation-rake edit task env-vars)) (let ((default-directory ...)) (setq ad-return-value (ad-Orig-ruby-compilation-rake edit task env-vars)) (rinari-launch)) (let (ad-return-value) (let (...) (setq ad-return-value ...) (rinari-launch)) ad-return-value) ruby-compilation-rake(nil nil nil) rinari-rake(nil) call-interactively(rinari-rake t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil)

purcell commented 11 years ago

Sorry for the slow response. It looks like compilation-save-buffers-predicate was introduced in Emacs 24, so I need to fix up ruby-compilation to make it backwards-compatible.