eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

rinari-web-server doesn't work with latest version of ruby-compilation-mode #62

Closed shosti closed 11 years ago

shosti commented 11 years ago

rinari-web-server fails with error (wrong-type-argument stringp nil) since the latest update to ruby-compilation-mode (I tried with versions from MELPA and from Marmalade, and they all failed). At first I thought it was a problem with my configuration (maybe a conflict with rvm.el), but the same error happens with a vanilla emacs install. Here's the backtrace I got on a vanilla emacs install:

Debugger entered--Lisp error: (wrong-type-argument stringp nil) set-buffer(nil) (save-current-buffer (set-buffer existing-buffer) (setq default-directory this-dir)) (let ((this-dir default-directory) (existing-buffer (get-buffer (concat "*" name "*")))) (save-current-buffer (set-buffer existing-buffer) (setq default-directory this-dir))) ad-Orig-ruby-compilation-do("server" ("ruby" "/usr/bin/rails" "server")) ruby-compilation-do("server" ("ruby" "/usr/bin/rails" "server")) (pop-to-buffer (ruby-compilation-do name cmdlist)) (let ((name (or name (file-name-nondirectory (car (split-string cmd))))) (cmdlist (append (list ruby-compilation-executable) ruby-options (split-string (expand-file-name cmd))))) (pop-to-buffer (ruby-compilation-do name cmdlist))) ruby-compilation-run("/usr/bin/rails server" nil "server") (let* ((default-directory (rinari-root)) (command (rinari--wrap-rails-command "server"))) (if rinari-rails-env (progn (setq command (concat command " -e " rinari-rails-env)))) (setq command (if edit-cmd-args (read-string "Run Ruby: " (concat command " ")) command)) (ruby-compilation-run command nil "server")) rinari-web-server(nil) call-interactively(rinari-web-server nil nil)

purcell commented 11 years ago

Erk, sorry. I'll take a look.

purcell commented 11 years ago

Okay, there's a fix in the repo and up on Marmalade now, and MELPA will build a new package soon too.

Thanks for taking the time to report the issue, and apologies once again.

-Steve