search

eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

remove local override of existing global binding for C-x C-t, and ignore Gemfile.lock #67

Closed aspiers closed 11 years ago

purcell commented 11 years ago

Thanks Adam.

Wasn't the problem here that C-x C-t was described as being bound to ruby-compilation-this-buffer, while it was actually bound to ruby-compilation-this-test? Your patch removes both the incorrect documentation line and the binding itself, which is still useful unless I'm mistaken.

purcell commented 11 years ago

(To clarify: I'm not particularly concerned that C-x C-t shadows transpose-lines, because I believe that M-t is the more commonly used binding for that command.)

purcell commented 11 years ago

I've cherry-picked your gitignore fix, and corrected the docstring regarding the bindings.

dgutov commented 11 years ago

I believe that M-t is the more commonly used binding for that command

M-t is transpose-words. I never use transpose-lines, though.

purcell commented 11 years ago

Right, sorry, I meant M-T.

dgutov commented 11 years ago

Not bound to anything here.

purcell commented 11 years ago

LOL, true -- looks like that's a custom binding I've added for myself and never used... Maybe I'll see if there's a good alternative binding we can use for ruby-compilation-current-test...

aspiers commented 11 years ago

Sorry - the typo in the documentation line led to me writing a slightly inaccurate commit message (yes it should have referred to ruby-compilation-this-test not ruby-compilation-this-buffer), but the key point behind this pull request is to stop overriding transpose-lines which is an unacceptable override IMHO. Why not bind ruby-compilation-this-test to C-x T?

(FWIW, I have also bound M-T, but to transpose-words.)

dgutov commented 11 years ago

Using the C-c prefix would be better, C-x is usually reserved for standard commands and the user bindings.

aspiers commented 11 years ago

That's an inaccurate generalisation about C-c. Please see http://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html

purcell commented 11 years ago

Thanks for clarifying.

  1. I will change the default binding to C-x T
  2. M-t is already transpose-words, so M-T seems redundant
  3. Isn't Emacs wonderful?
aspiers commented 11 years ago
  1. Thanks!
  2. Why?
  3. Yes indeed ;-)
purcell commented 11 years ago
  1. Because now you presumably have both M-t and M-T bound to transpose-words...?
purcell commented 11 years ago

Hah - I numbered that "2", but Markdown converted it to 1.

aspiers commented 11 years ago

Sorry, I meant transpose-sentences.

purcell commented 11 years ago

Aha - got it! Another function I've never used in anger.