eschulte / rinari

Rinari Is Not A Rails IDE (it is an Emacs minor mode for Rails)
http://rinari.rubyforge.org
GNU General Public License v3.0
412 stars 68 forks source link

Fixed the problem of the rinari-web-server failing with Windows Platform. #86

Closed erw7 closed 9 years ago

erw7 commented 9 years ago

Added a new argument not-append-executable to rinari--wrap-rails-command function, modified not append ruby-compilation-executabe when do not need.

purcell commented 9 years ago

Thanks for this, but I don't really understand what the problem was here. The fix looks like it's not going to be the best solution on every platform, so I'd like to understand what issues you were seeing with the existing code.

erw7 commented 9 years ago

rinari--wrap-rails-command has been used in rinari-console, rinari-generate, rinari-script, rinari-web-server.

rinari-script, rinari-web-server call ruby-compilation-run. ruby-compilation-run also append the ruby-compilation-executable, will be append twice. So ruby-compilation-run fail ruby-compilation-excutable try to run ruby-compilation-excutable as a ruby script.

But rinari-console is to run command with the run-ruby. rinari-generate is to run command with the shell-command-to-string. If script file do not have permission to execute, these shuld append the ruby-compilation-executable.

purcell commented 9 years ago

Thanks for the explanation. Makes sense. I fixed this slightly differently in 5a44c47 -- please let me know if it doesn't work for you.

erw7 commented 9 years ago

Thaks. Your code work fine for me.

erw7 commented 9 years ago

Now probably we can close #52, too.

purcell commented 9 years ago

Done - thanks.