Added options param explicitly to all constructors

eschwartz / backbone.googlemaps

A Backbone JS extension for interacting with the Google Maps API (v3.10)

MIT License

139 stars 55 forks source link

Added options param explicitly to all constructors #18

Closed variousauthors closed 10 years ago

variousauthors commented 10 years ago

This fixes a bug introduced by fixes from Backbone 1.1.0 (see changelog, and issue #17)

cajund commented 10 years ago

I'm going to second this change. However, I would suggest - in the interest of minimal code changes - you do something like this:

constructor: function(options) (
    ...
this.options = options;
    ...
)

eschwartz commented 10 years ago

Fixed by 494bc93bf506d48a202b9b014c62853853498b46

For the other commits in this pull request, I would request that you create separate requests for each new feature / fix, so I can address them individually. Also please not that I am not accepting pull requests for new functionality (see my notes here)