search

eschwartz / backbone.googlemaps

A Backbone JS extension for interacting with the Google Maps API (v3.10)
MIT License
139 stars 55 forks source link

Make the library AMD aware so that it can be used in a CommonJS or requirejs environment #6

Closed peterlong closed 11 years ago

eschwartz commented 11 years ago

Thanks for the pull request, @peterlong . My only concern is out of ignorance -- AMD is still on my backlog things to learn.

I would feel more comfortable merging this if you could find someone who is familiar with AMD to review and verify your commit. If you can find someone to do that, just have them make a note here, and I'll merge the request.

I've confirmed that this doesn't break anything in a non-AMD environment.

Sorry for the slow response!

jrburke commented 11 years ago

@peterlong I did another pass at this in #11, see comments there.

peterlong commented 11 years ago

Closing this pull request in favor of #11 by @jrburke