search

eschweitzer78 / gps-design-systems-lwc

Salesforce LWCs for Australian, French and UK Governments' Design Systems
Other
12 stars 10 forks source link

Unable to VIC unlocked package in Production #316

Closed batesbw closed 7 months ago

batesbw commented 8 months ago

Summary

Unable to install Vic unlocked package into Prod org

Salesforce Org Type

Production Org

Steps To Reproduce

Follow instructions on Readme to install into production

Current Behavior

he component included in step 5 on the below screenshot contains the theme. I installed the pre-requisite component in Step 2, but unable to finish the step 5.

image

I could not install the package linked from Step 5 due to errors encountered. I resolved the 2 errors highlighted in GREEN (manually cloned the repo and pushed only the missing apex/lwc) below but I cannot resolve the first one highlighted in red since it is missing from the git repository. There is an LCW with almost similar name “sfGpsDsOmniHelpersOsN” but haven’t tried this one yet as it seems to contain a function not visibly relevant with how the dependent component is trying to call it, we can take a shot though.. or maybe Jase has this component on your previous project, something we can try to pull?

image

Expected Behavior

Installation is correct

Relevant Log Output

See image in current behaviour

Code of Conduct

github-actions[bot] commented 8 months ago

Welcome! 👋

Thank you for posting this issue. 🙇🏼‍♂️ We will come back to you latest within the next 48h (working days). Stay tuned!

eschweitzer78 commented 8 months ago

Hi Benjamin and thank you so much for reporting the issue. Upon closer inspection, it looks like it may be linked to a faulty build logic which has been corrected since. As a result, I have promoted the current sandbox packages for production use.

Please try https://login.salesforce.com/packaging/installPackage.apexp?p0=04t5j000000dzFEAAY for the VIC Ripple 1 Design System and let me know how you're doing.

Kindly note that sfGpsDs is no longer a prerequisite for this version. If you have sfGpsDs installed in production, please refer to https://github.com/eschweitzer78/gps-design-systems-lwc?tab=readme-ov-file#moving-away-from-separate-base-and-design-system-libraries

batesbw commented 8 months ago

Thanks so much for the quick turnaround Emmanuel, i'll forward to the team and get back to you. Cheers, Ben

eschweitzer78 commented 8 months ago

FYI I edited the original response to add the following -- I am not sure this was reflected in the automated email you may have received:

Kindly note that sfGpsDs is no longer a prerequisite for this version. If you have sfGpsDs installed in production, please refer to https://github.com/eschweitzer78/gps-design-systems-lwc?tab=readme-ov-file#moving-away-from-separate-base-and-design-system-libraries

eschweitzer78 commented 7 months ago

Hi @batesbw may I close the issue?

batesbw commented 7 months ago

Yes, apologies!