search

esciencecenter-digital-skills / Lesson-FAIR-Data-Climate

https://esciencecenter-digital-skills.github.io/Lesson-FAIR-Data-Climate/
Other
1 stars 5 forks source link

Add some refs. and comments. #38

Closed arnikz closed 4 years ago

Peter9192 commented 4 years ago

@SarahAlidoost or @stefsmeets would one of you have some time to look at this PR? Consider it up to us to finish the PR and get it merged.

arnikz commented 4 years ago

@stefsmeets: Sorry, I won't have time to go over it one-by-one. Feel free to take on board some of the suggestions.

stefsmeets commented 4 years ago

@stefsmeets: Sorry, I won't have time to go over it one-by-one. Feel free to take on board some of the suggestions.

Cheers, I misunderstood the purpose of this PR the first time around. I realized you just meant to add some notes, because there is no easy way to do so otherwise. We can take over from here.

Peter9192 commented 4 years ago

@Peter9192 Is it an idea to open a new issue to have a look at these comments in more detail?

Yes. I think some of the suggestions can easily be applied or added right away (text suggestions, additional references, and so on). For the more involved feedback points, it would be good to open new issues and maybe already do a little bit of research into how to address them.

stefsmeets commented 4 years ago

Hi @Peter9192 , could you go through my comments and approve them to finish this PR? I summarized all the remaining the comments from @arnikz which require a bit more thought in a new issue: #39