search

esciencecenter-digital-skills / geospatial-python

Introduction to Geospatial Raster and Vector Data with Python
https://esciencecenter-digital-skills.github.io/geospatial-python/
Other
3 stars 0 forks source link

update E6: raster introduction #10

Closed rogerkuou closed 2 years ago

rogerkuou commented 2 years ago

Solving #3

rogerkuou commented 2 years ago

Hi @cpranav93 @SarahAlidoost and @fnattino , thanks a lot for all of your comments and suggestions. I applied most of them. For the ones I did not apply, I replied to the thread. Would you like to have a look at the updated version?

And Ryan @rbavery I think it is now in a good shape for a final review. Would you like to have a look on this episode?

rbavery commented 2 years ago

Hi @cpranav93 @SarahAlidoost and @fnattino , thanks a lot for all of your comments and suggestions. I applied most of them. For the ones I did not apply, I replied to the thread. Would you like to have a look at the updated version?

And Ryan @rbavery I think it is now in a good shape for a final review. Would you like to have a look on this episode?

I would! unfortunately I'm pretty booked up this week preparing to be a panelist for a NASA Roses proposal review session. I'll have time to review this after May 18th. If that's too late feel free to merge it here and I can look at the PR to the carpentries repo soon after May 18th.

rogerkuou commented 2 years ago

Hi @cpranav93 @SarahAlidoost and @fnattino , thanks a lot for all of your comments and suggestions. I applied most of them. For the ones I did not apply, I replied to the thread. Would you like to have a look at the updated version? And Ryan @rbavery I think it is now in a good shape for a final review. Would you like to have a look on this episode?

I would! unfortunately I'm pretty booked up this week preparing to be a panelist for a NASA Roses proposal review session. I'll have time to review this after May 18th. If that's too late feel free to merge it here and I can look at the PR to the carpentries repo soon after May 18th.

Hi @rbavery no problem! We are aiming at having the first version of the lesson ready before May 31st, therefore May 18 is totally fine. I will wait for your feedback first.

rogerkuou commented 2 years ago

@rbavery Hi Ryan, may I ask do you have time to take a look at this episode?

rbavery commented 2 years ago

@rogerkuou I do, thanks for the ping. Now that I'm situated for the next week and not traveling I'll have time to focus on this. Will give this a thorough review today.

rogerkuou commented 2 years ago

@rbavery Thx for the review! I adapted most of your comments. Only two remain. The table of contents can be solved later. And was not completely sure about the false color. I replied under both of them. Would you like to give another look?

rbavery commented 2 years ago

@rogerkuou looks good to merge!