search

esciencecenter-digital-skills / geospatial-python

Introduction to Geospatial Raster and Vector Data with Python
https://esciencecenter-digital-skills.github.io/geospatial-python/
Other
3 stars 0 forks source link

Fix datasets #57

Closed fnattino closed 1 year ago

fnattino commented 1 year ago

Closes #14 . I have made it such that all files generated by the lesson are stored in the current working directory, while the input vector files are in the data directory. Not sure whether this is the best, but it might simplifies the life of participants tracking what needs to be loaded in, and it would be consistent with the best practices taught by other Carpentries' lessons where you should not save output in the same folder as input..

fnattino commented 1 year ago

@rogerkuou , still missing the callouts within each chapter, but you can go ahead and review what is there so far

fnattino commented 1 year ago

Also, just to check, are we following the convention of saving the downloaded file in data, and exporting data to the working directory?

Yes, this is what I thought would be best (everything that is saved from within the lesson is saved in the current working directory to avoid mixing it with the input files).

fnattino commented 1 year ago

Hi @rogerkuou, callouts to introduce the data (and the alternative download method) have been introduced, can you have a look? When this and #59 are merged we can then open the big upstream PR