search

esciencecenter-digital-skills / geospatial-python

Introduction to Geospatial Raster and Vector Data with Python
https://esciencecenter-digital-skills.github.io/geospatial-python/
Other
3 stars 0 forks source link

added message to branch #94

Closed Morrizzzzz closed 8 months ago

Morrizzzzz commented 9 months ago

Hi @rogerkuou

I just added an example, please do not merge yet, I will inform you when it is.

I am going to work on:

Cheers, Maurice

github-actions[bot] commented 9 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-94

The following changes were observed in the rendered markdown documents:

 md5sum.txt         |  3 +-
 narrative.md (new) | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 setup.md           |  2 +-
 3 files changed, 90 insertions(+), 2 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2023-10-03 15:26:06 +0000

Morrizzzzz commented 9 months ago

@rogerkuou

Great work!

I just added a some text in the notebook and went through all the steps. One minor comment, now that I also looked a little in the literature I changed forest fires into wild fires, which is basically the "parent" of forest fires.

Furthermore I was wondering why we are projecting it and then undo that? In every GIS project I would always first allign all my data to a projected coordinate system. Also (out of habit) I try to project it as UTM data.

I guess my PR is now ready for review! ;-)

rogerkuou commented 8 months ago

@Morrizzzzz Thanks! The text looks awesome. They can be quite useful when we update the course curriculum later. I will merge it now.