search

esciencecenter-digital-skills / research-software-support

Content for the Research Software Support platform
https://esciencecenter-digital-skills.github.io/research-software-support/
Other
3 stars 4 forks source link

Images broken? #61

Closed LourensVeen closed 6 months ago

LourensVeen commented 6 months ago

I'm seeing broken image links in the slides at e.g. https://esciencecenter-digital-skills.github.io/research-software-support/modules/licenses/slides. Seems like e.g. https://esciencecenter-digital-skills.github.io/nlesc_style_files/letter-e.svg doesn't exist?

raar1 commented 6 months ago

The problem is that nuxt serves images in its public/ directory on the root path (/) by default (and routes accordingly). This works fine if you run it locally. However, it seems that on ghpages these files are at a URL that includes the repo prefix.

If you look at https://esciencecenter-digital-skills.github.io/research-software-support/nlesc_style_files/letter-e.svg for example, you'll find the white e... It's very annoying.

I'm currently fixing it now (now that I have a working laptop again).

raar1 commented 6 months ago

This was fixed in PR https://github.com/esciencecenter-digital-skills/NEBULA/pull/40

Seems to be working on deployed page now