search

esciencecenter-digital-skills / research-software-support

Content for the Research Software Support platform
https://esciencecenter-digital-skills.github.io/research-software-support/
Other
3 stars 4 forks source link

Add licensing module ordering #68

Closed LourensVeen closed 5 months ago

LourensVeen commented 6 months ago

This orders the Licensing module using the new metadata tags, and introduces shorter titles for the title cards. I haven't managed to test it locally, but am hoping for the best :smile:.

See #51.

LourensVeen commented 6 months ago

I failed to git pull, so we had a conflict with the changes that Carlos made. I've blended our contributions together and now it's passing. Yay!

JaroCamphuijsen commented 6 months ago

@LourensVeen should someone review this PR? Can you request someone?

LourensVeen commented 6 months ago

Oh yeah probably, now that we're done teaching and it won't change in the middle of the lesson :smile:.

I'll nominate Qarlos, since I so rudely changed his changes.

LourensVeen commented 6 months ago

Yes, I should do that, but probably in a new PR in the next sprint in two weeks. This one already makes two changes and I'd rather not let the scope creep any further.

LourensVeen commented 5 months ago

I'm just going to be so bold as to merge this. It's Friday after all. YOLO!